Subj : New Defects reported by Coverity Scan for Synchronet
To   : All
From : scan-admin@coverity.com
Date : Wed Jan 28 2026 01:46 pm


----==_mimepart_697a13306f491_cf6782d0dbe50d9a0894b
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

3 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 642982:         (FORWARD_NULL)
/prntfile.cpp: 263           in sbbs_t::printfile(const char *, int, int, JSObject *)()
/prntfile.cpp: 228           in sbbs_t::printfile(const char *, int, int, JSObject *)()


_____________________________________________________________________________________________
*** CID 642982:           (FORWARD_NULL)
/prntfile.cpp: 263             in sbbs_t::printfile(const char *, int, int, JSObject *)()
257     					default:
258     					case TERM_KEY_DOWN:
259     						nextline = line + 1;
260     						break;
261     				}
262     				if (nextline != line + 1 && nextline < lines)
>>>     CID 642982:           (FORWARD_NULL)
>>>     Dereferencing null pointer "offset".
263     					fseeko(stream, offset[nextline], 0);
264     				line = nextline;
265     			}
266     			else
267     				++line;
268     		}
/prntfile.cpp: 228             in sbbs_t::printfile(const char *, int, int, JSObject *)()
222     						else
223     							nextline = line - (((term->rows - 1) * 2) - 1);
224     						break;
225     					case TERM_KEY_END:
226     					{
227     						bputs(text[SeekingFile]);
>>>     CID 642982:           (FORWARD_NULL)
>>>     Dereferencing null pointer "offset".
228     						fseeko(stream, offset[lines - 1], SEEK_SET);
229     						if (fgets(buf, length + 1, stream) == NULL)
230     							break;
231     						off_t lastline = lines - 1;
232     						while (!feof(stream) && !msgabort()) {
233     							o = ftello(stream);

** CID 642981:       Error handling issues  (CHECKED_RETURN)
/prntfile.cpp: 228           in sbbs_t::printfile(const char *, int, int, JSObject *)()


_____________________________________________________________________________________________
*** CID 642981:         Error handling issues  (CHECKED_RETURN)
/prntfile.cpp: 228             in sbbs_t::printfile(const char *, int, int, JSObject *)()
222     						else
223     							nextline = line - (((term->rows - 1) * 2) - 1);
224     						break;
225     					case TERM_KEY_END:
226     					{
227     						bputs(text[SeekingFile]);
>>>     CID 642981:         Error handling issues  (CHECKED_RETURN)
>>>     Calling "fseeko(stream, offset[lines - 1UL], 0)" without checking return value. This library function may fail and return an error code.
228     						fseeko(stream, offset[lines - 1], SEEK_SET);
229     						if (fgets(buf, length + 1, stream) == NULL)
230     							break;
231     						off_t lastline = lines - 1;
232     						while (!feof(stream) && !msgabort()) {
233     							o = ftello(stream);

** CID 642980:       Integer handling issues  (INTEGER_OVERFLOW)
/prntfile.cpp: 228           in sbbs_t::printfile(const char *, int, int, JSObject *)()


_____________________________________________________________________________________________
*** CID 642980:         Integer handling issues  (INTEGER_OVERFLOW)
/prntfile.cpp: 228             in sbbs_t::printfile(const char *, int, int, JSObject *)()
222     						else
223     							nextline = line - (((term->rows - 1) * 2) - 1);
224     						break;
225     					case TERM_KEY_END:
226     					{
227     						bputs(text[SeekingFile]);
>>>     CID 642980:         Integer handling issues  (INTEGER_OVERFLOW)
>>>     Expression "lines - 1UL", where "lines" is known to be equal to 0, underflows the type of "lines - 1UL", which is type "unsigned long".
228     						fseeko(stream, offset[lines - 1], SEEK_SET);
229     						if (fgets(buf, length + 1, stream) == NULL)
230     							break;
231     						off_t lastline = lines - 1;
232     						while (!feof(stream) && !msgabort()) {
233     							o = ftello(stream);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


----==_mimepart_697a13306f491_cf6782d0dbe50d9a0894b
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
<head>
  <meta charset="UTF-8">
  <title>New Defects Reported - Synchronet</title>
  <style>
    body { font-family: Arial, sans-serif; color: #222; line-height: 1.6; }
    .button {
      display: inline-block;
      padding: 10px 20px;
      margin: 20px 0;
      font-size: 16px;
      color: #fff !important;
      background-color: #0056b3;
      text-decoration: none;
      border-radius: 5px;
    }
    pre {
      background: #f8f9fa;
      padding: 10px;
      border-radius: 5px;
      font-size: 14px;
      overflow-x: auto;
    }
  </style>
</head>
<body>
  <p>Hi,</p>

  <p>
    Please find the latest report on new defect(s) introduced to <strong>Synchronet</strong>
     found with Coverity Scan.
  </p>

  <ul>
    <li><strong>New Defects Found:</strong> 3</li>
    <li><strong>Defects Shown:</strong> Showing 3 of 3 defect(s)</li>
  </ul>

  <h3>Defect Details</h3>
  <pre>
** CID 642982:         (FORWARD_NULL)
/prntfile.cpp: 263           in sbbs_t::printfile(const char *, int, int, JSObject *)()
/prntfile.cpp: 228           in sbbs_t::printfile(const char *, int, int, JSObject *)()


_____________________________________________________________________________________________
*** CID 642982:           (FORWARD_NULL)
/prntfile.cpp: 263             in sbbs_t::printfile(const char *, int, int, JSObject *)()
257     					default:
258     					case TERM_KEY_DOWN:
259     						nextline = line + 1;
260     						break;
261     				}
262     				if (nextline != line + 1 &amp;&amp; nextline &lt; lines)
&gt;&gt;&gt;     CID 642982:           (FORWARD_NULL)
&gt;&gt;&gt;     Dereferencing null pointer &quot;offset&quot;.
263     					fseeko(stream, offset[nextline], 0);
264     				line = nextline;
265     			}
266     			else
267     				++line;
268     		}
/prntfile.cpp: 228             in sbbs_t::printfile(const char *, int, int, JSObject *)()
222     						else
223     							nextline = line - (((term-&gt;rows - 1) * 2) - 1);
224     						break;
225     					case TERM_KEY_END:
226     					{
227     						bputs(text[SeekingFile]);
&gt;&gt;&gt;     CID 642982:           (FORWARD_NULL)
&gt;&gt;&gt;     Dereferencing null pointer &quot;offset&quot;.
228     						fseeko(stream, offset[lines - 1], SEEK_SET);
229     						if (fgets(buf, length + 1, stream) == NULL)
230     							break;
231     						off_t lastline = lines - 1;
232     						while (!feof(stream) &amp;&amp; !msgabort()) {
233     							o = ftello(stream);

** CID 642981:       Error handling issues  (CHECKED_RETURN)
/prntfile.cpp: 228           in sbbs_t::printfile(const char *, int, int, JSObject *)()


_____________________________________________________________________________________________
*** CID 642981:         Error handling issues  (CHECKED_RETURN)
/prntfile.cpp: 228             in sbbs_t::printfile(const char *, int, int, JSObject *)()
222     						else
223     							nextline = line - (((term-&gt;rows - 1) * 2) - 1);
224     						break;
225     					case TERM_KEY_END:
226     					{
227     						bputs(text[SeekingFile]);
&gt;&gt;&gt;     CID 642981:         Error handling issues  (CHECKED_RETURN)
&gt;&gt;&gt;     Calling &quot;fseeko(stream, offset[lines - 1UL], 0)&quot; without checking return value. This library function may fail and return an error code.
228     						fseeko(stream, offset[lines - 1], SEEK_SET);
229     						if (fgets(buf, length + 1, stream) == NULL)
230     							break;
231     						off_t lastline = lines - 1;
232     						while (!feof(stream) &amp;&amp; !msgabort()) {
233     							o = ftello(stream);

** CID 642980:       Integer handling issues  (INTEGER_OVERFLOW)
/prntfile.cpp: 228           in sbbs_t::printfile(const char *, int, int, JSObject *)()


_____________________________________________________________________________________________
*** CID 642980:         Integer handling issues  (INTEGER_OVERFLOW)
/prntfile.cpp: 228             in sbbs_t::printfile(const char *, int, int, JSObject *)()
222     						else
223     							nextline = line - (((term-&gt;rows - 1) * 2) - 1);
224     						break;
225     					case TERM_KEY_END:
226     					{
227     						bputs(text[SeekingFile]);
&gt;&gt;&gt;     CID 642980:         Integer handling issues  (INTEGER_OVERFLOW)
&gt;&gt;&gt;     Expression &quot;lines - 1UL&quot;, where &quot;lines&quot; is known to be equal to 0, underflows the type of &quot;lines - 1UL&quot;, which is type &quot;unsigned long&quot;.
228     						fseeko(stream, offset[lines - 1], SEEK_SET);
229     						if (fgets(buf, length + 1, stream) == NULL)
230     							break;
231     						off_t lastline = lines - 1;
232     						while (!feof(stream) &amp;&amp; !msgabort()) {
233     							o = ftello(stream);

  </pre>

  <p>
    <a href="https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
  </p>

  <p>Best regards,</p>
  <p>The Coverity Scan Admin Team</p>
  <img class="logo" width="140" src="https://scan.coverity.com/assets/BlackDuckLogo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" />
</body>
</html>
----==_mimepart_697a13306f491_cf6782d0dbe50d9a0894b--


.