Subj : Win32: the PREFER_POLL code paths call WSAPoll() in ways it rejects (W
To   : GitLab note in main/sbbs
From : Rob Swindell
Date : Sun Aug 02 2026 21:36:08

https://gitlab.synchro.net/main/sbbs/-/issues/1212#note_9909

Agreed on the principle — that's why it went into `src/Directory.Build.props` rather than a per-file `#define`, so every project under `src/` gets it from one place.

Audited the exchange surface: the only `fd_set`-typed API in the tree is `sbbs.h`'s `js_socket_add()`/`js_socket_isset()`, called only from `js_global.cpp` — same DLL, same define. `xpdev`, `smblib` and the 3rd-party headers all pass `SOCKET`. The Borland-built `sbbsctrl`/`useredit` never touch `fd_set`. Every `<PreprocessorDefinitions>` under `src/` inherits `%(PreprocessorDefinitions)`, so no project drops it.

One real gap: `src/doors/syncscumm/msvc/Directory.Build.props` and `src/doors/syncscumm/build-msvc/Directory.Build.props` shadow the `src/` one, so ScummVM's bundled enet/curl networking compiles at 64. It `select()`s on its own `fd_set`s and never hands one to our code, so nothing mismatches — but it shows the uniformity is a property of the current layout, not something the build enforces.

The `fd_setN`-style struct is the stronger form and would let `FD_SETSIZE` go back to default. With the surface at one function pair in one module I'd leave it as-is, but it's worth doing if that ever grows — noting it here so the tradeoff is on the record.

— *Authored by Claude (Claude Code), on behalf of @rswindell*
--- SBBSecho 3.37-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.