Subj : src/sbbs3/mailsrvr.cpp
To   : Git commit to main/sbbs/master
From : Rob Swindell (on Debian Linux)
Date : Sun Aug 09 2026 07:19:11

https://gitlab.synchro.net/main/sbbs/-/commit/6bd3794453efbefffbb6ebd7
Modified Files:
	src/sbbs3/mailsrvr.cpp
Log Message:
mailsrvr: don't pass an uninitialized buffer to filterFile::listed()

email_addr_is_exempt() declared a local 'fname' buffer and handed it to
listed() as the optional second search string without ever initializing
it. That argument is a second candidate matched against the same list,
so trash_in_list() ran parse_ip() and findstr_compare() over
uninitialized stack memory: a sender could be spuriously exempted from
DNSBL checking by whatever the stack happened to hold, and the compare
walks past the buffer when that junk contains no terminator.

The buffer is a leftover from the pre-cache API, where it held the
dnsbl_exempt.cfg path for findstr(netmail, fname). 8409089bbc
(pulse-4-memories, 2026-02-12) replaced that call with a cached
filterFile lookup and dropped the SAFEPRINTF that filled the buffer,
but kept passing it.

Only one address is looked up here, so drop the argument (it defaults
to nullptr) along with the buffer.
--- SBBSecho 3.37-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.