Subj : New Defects reported by Coverity Scan for Synchronet
To   : All
From : scan-admin@coverity.com
Date : Tue Jun 23 2026 12:49:12

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 646963:       Concurrent data access violations  (MISSING_LOCK)
/echocfg.c: 863           in main()


_____________________________________________________________________________________________
*** CID 646963:         Concurrent data access violations  (MISSING_LOCK)
/echocfg.c: 863             in main()
857     					uifc.mode |= UIFC_COLOR;
858     					break;
859     				case 'V':
860     					video_mode = atoi(argv[i] + 2);
861     					break;
862     				case 'S':
>>>     CID 646963:         Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "ciolib_initial_scaling" without holding lock "vstatlock". Elsewhere, "ciolib_initial_scaling" is written to with "vstatlock" held 5 out of 7 times.
863     					ciolib_initial_scaling = strtod(argv[i] + 2, NULL);
864     					break;
865     				default:
866     USAGE:
867     #ifdef _WIN32
868     					uifc.size = sizeof(uifc);

** CID 646962:       Concurrent data access violations  (MISSING_LOCK)
/tmp/sbbs-Jun-23-2026/src/conio/sdl_con.c: 408           in sdl_init()


_____________________________________________________________________________________________
*** CID 646962:         Concurrent data access violations  (MISSING_LOCK)
/tmp/sbbs-Jun-23-2026/src/conio/sdl_con.c: 408             in sdl_init()
402
403     /* Called from main thread only (Passes Event) */
404     int sdl_init(int mode)
405     {
406     	load_vmode(&vstat, ciolib_initial_mode);
407     	if (vstat.scaling < 1.0)
>>>     CID 646962:         Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "ciolib_initial_scaling" without holding lock "vstatlock". Elsewhere, "ciolib_initial_scaling" is written to with "vstatlock" held 5 out of 7 times.
408     		vstat.scaling = ciolib_initial_scaling;
409     	if (vstat.scaling < 1.0)
410     		vstat.scaling = 1.0;
411     	// TODO: This is gross, why do we need it?
412     	vstat.winwidth = vstat.scrnwidth * vstat.scaling;
413     	vstat.winheight = vstat.scrnheight * vstat.scaling;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
 * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

.